Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler should be able to recompile a file #1892

Open
phated opened this issue Jul 7, 2023 · 2 comments
Open

Compiler should be able to recompile a file #1892

phated opened this issue Jul 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jul 7, 2023

Problem

Currently, the compiler expects a clean-slate environment and builds the entire program from scratch. However, in the LSP, we want to build the project once and then recompile individual files with the same Context. This isn't possible currently because the compiler returns immediately if it sees a CrateID in the def_map.

Happy Case

We should be able to create a Context once and build the entire project once, then afterwards we should be able to compile a single file given the stored Context.

Alternatives Considered

No response

Additional Context

Ref #1891

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@phated phated added the enhancement New feature or request label Jul 7, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 7, 2023
@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2023

I assume this is because of the recent change to avoid recompiling the same file when it is required by multiple crate dependencies. We'll still want to avoid recompiling in that case so perhaps we need to store timestamps and check when each file was last changed as well.

@kevaundray
Copy link
Contributor

+1 Having a checksum for build artifacts is a good stepping-stone here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants