Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive types can have impl inside dependencies #1894

Closed
phated opened this issue Jul 7, 2023 · 0 comments · Fixed by #1895
Closed

Primitive types can have impl inside dependencies #1894

phated opened this issue Jul 7, 2023 · 0 comments · Fixed by #1895
Assignees
Labels
bug Something isn't working

Comments

@phated
Copy link
Contributor

phated commented Jul 7, 2023

Aim

I tested adding impl Field to a dependency and including it into my project and the compiler did not error.

Expected Behavior

The compiler should error if primitives are impld in a dependency.

Bug

The compiler doesn't error.

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

Inside of collect_impls there is a note about this behavior but no TODO or issue that I could find.

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the bug Something isn't working label Jul 7, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 7, 2023
@phated phated self-assigned this Jul 7, 2023
@phated phated moved this from 📋 Backlog to 🏗 In progress in Noir Jul 7, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant