Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compile to brillig reachable acir fns #1919

Merged
merged 5 commits into from
Jul 13, 2023
Merged

feat: compile to brillig reachable acir fns #1919

merged 5 commits into from
Jul 13, 2023

Conversation

sirasistant
Copy link
Contributor

Description

Problem*

Utility constrained functions called from unconstrained should be automatically converted to brillig, to avoid code duplication into constrained and unconstrained versions.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray enabled auto-merge July 13, 2023 11:27
@kevaundray kevaundray added this pull request to the merge queue Jul 13, 2023
Merged via the queue into master with commit 2b4237d Jul 13, 2023
@kevaundray kevaundray deleted the arv/acir_as_brillig branch July 13, 2023 11:46
@kevaundray kevaundray mentioned this pull request Jul 13, 2023
Merged
@sirasistant sirasistant mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@ludamad ludamad Awaiting requested review from ludamad

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirasistant @kevaundray