Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Emit opcodes for sorting variables in order of execution #1941

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: Emit opcodes for sorting variables in order of execution #1941

merged 1 commit into from
Jul 17, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This pulls out the changes from #1929 which don't rely on changes to the ACVM.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title fix: emit opcodes for sorting variables in order of execution fix: Emit opcodes for sorting variables in order of execution Jul 17, 2023
@kevaundray kevaundray added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit c43efab Jul 17, 2023
@kevaundray kevaundray deleted the fix-permutation-ordering branch July 17, 2023 11:01
@kevaundray kevaundray mentioned this pull request Jul 17, 2023
Merged
@TomAFrench TomAFrench mentioned this pull request Jul 17, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@guipublic guipublic Awaiting requested review from guipublic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray