Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rationale as to why we create a new array with zero values #2016

Closed
kevaundray opened this issue Jul 24, 2023 · 0 comments · Fixed by #2106
Closed

Add rationale as to why we create a new array with zero values #2016

kevaundray opened this issue Jul 24, 2023 · 0 comments · Fixed by #2106
Assignees
Labels
acir-gen enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

See : #1969 (comment)

When we do an array_set, we create a new array with zero values, then copy the old array into this new array, overwriting the zeroes.

Question was referring to why we don't just copy the new values into the array initially

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acir-gen enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants