Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ACIR + witness artifacts for Barretenberg using experimental-ssa #2020

Closed
Tracked by #2021
TomAFrench opened this issue Jul 24, 2023 · 2 comments · Fixed by #2023
Closed
Tracked by #2021

Create ACIR + witness artifacts for Barretenberg using experimental-ssa #2020

TomAFrench opened this issue Jul 24, 2023 · 2 comments · Fixed by #2023
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

Barretenberg uses the committed ACIR and witness files in the test_data directory in order to test ACIR proof generation. As we switch over to using the new SSA by default we want to ensure that Barretenberg has test coverage for this.

Happy Case

We should run the rebuild.sh script on the test_data_ssa_refactor directory and update Barretenberg to pull these and run its tests on them.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@TomAFrench
Copy link
Member Author

This would be a good opportunity to move to the directory structure as set out in #2013

@kevaundray
Copy link
Contributor

I think #2013 should be done separately so it doesn't hold us up

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants