Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nargo entry points should be configurable via Nargo.toml #2076

Closed
phated opened this issue Jul 27, 2023 · 1 comment · Fixed by #2158
Closed

Nargo entry points should be configurable via Nargo.toml #2076

phated opened this issue Jul 27, 2023 · 1 comment · Fixed by #2158
Assignees
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jul 27, 2023

Problem

Currently, nargo has hardcoded logic to search for a lib.nr or main.nr file to determine a CrateType. Since the CrateType will be specified in Nargo.toml with #2073, we can decouple the paths and allow them to be configured via Nargo.toml with defaults for lib.nr or main.nr if not specified.

Happy Case

A user can override the path to their entry point file, whether it is a lib, bin, or contract.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the enhancement New feature or request label Jul 27, 2023
@phated phated self-assigned this Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 27, 2023
@phated
Copy link
Contributor Author

phated commented Jul 27, 2023

Related to #1040 (cc @TomAFrench)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant