Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic message is confusing if dependency is missing a name field in toml #2086

Closed
phated opened this issue Jul 28, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jul 28, 2023

Problem

Now that we require package names in the Nargo.toml file, we present the user with a descriptive error message if they haven't set it. However, this error message is also surfaced for dependencies but there is no indication on which dependency caused it, which can be very confusing.

Happy Case

The error message should tell us which file is missing the name field.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@phated phated added the enhancement New feature or request label Jul 28, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 28, 2023
@iAmMichaelConnor
Copy link
Collaborator

Can confirm. :)
If I hadn't just read this it would have taken me a while to do the same for dependencies.

@TomAFrench
Copy link
Member

Not sure that we can really address this as we can't pass any information into the panic_missing_name function.

@phated
Copy link
Contributor Author

phated commented Aug 1, 2023

We can actually do better error messages once #1992 is merged because we can relax the toml parser and validate it when converting to a workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants