Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for Nargo.toml should not crawl past root #2261

Closed
phated opened this issue Aug 10, 2023 · 0 comments · Fixed by #2322
Closed

Searching for Nargo.toml should not crawl past root #2261

phated opened this issue Aug 10, 2023 · 0 comments · Fixed by #2322
Assignees
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Aug 10, 2023

Problem

Currently, the function that searches for Nargo.toml will look in every directory up to the root of you filesystem. However, this search should stop at some given root directory (usually the pwd of the nargo process, but maybe a --program-dir passed or the workspace root in the LSP)

Happy Case

The search should stop at some root.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

No response

@phated phated added the enhancement New feature or request label Aug 10, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 10, 2023
@phated phated self-assigned this Aug 10, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant