Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noir-wasm testing currently can only be ran in the CI #2318

Closed
kevaundray opened this issue Aug 15, 2023 · 0 comments · Fixed by #2319
Closed

Noir-wasm testing currently can only be ran in the CI #2318

kevaundray opened this issue Aug 15, 2023 · 0 comments · Fixed by #2319
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Currently the noir-wasm crate relies on a dist folder which is only ever created in the CI using the upload_artifacts option.

The contents of dist is just the contents of result, but as it stands you need to modify this to make test runnable

Happy Case

Unify the workflow so that tests can be ran locally without change and in the CI.

We could change the local code to create a dist folder or perhaps change the CI.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added enhancement New feature or request P-MEDIUM labels Aug 15, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 15, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant