Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wrapping functions in stdlib and use them in relevant test cases #2725

Merged
merged 7 commits into from
Sep 20, 2023
Merged

feat: add wrapping functions in stdlib and use them in relevant test cases #2725

merged 7 commits into from
Sep 20, 2023

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Some of our unit tests rely on the wrapping behaviour. Before changing the default behaviour (cf. issue #2459), we need to update those test cases with wrapping operations.

Related to #2459

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@guipublic guipublic marked this pull request as ready for review September 18, 2023 08:07
@guipublic
Copy link
Contributor Author

N.b: the CI is failing because signed integer arithmetic is not yet fully supported in noir

@kevaundray
Copy link
Contributor

Signed integer PR has been merged in so we can rebase ontop of master

jfecher
jfecher reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can move these functions to methods without much additional work

compiler/noirc_evaluator/src/ssa/ir/instruction/call.rs Outdated Show resolved Hide resolved
jfecher
jfecher approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make another PR now to move these functions to methods

@jfecher jfecher added this pull request to the merge queue Sep 20, 2023
Merged via the queue into master with commit 49ab121 Sep 20, 2023
@jfecher jfecher deleted the gd/wrapping branch September 20, 2023 13:58
@kevaundray kevaundray mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm left review comments

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guipublic @kevaundray @jfecher @vezenovm