Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove concept of array_set mut in brillig functions #6486

Closed
TomAFrench opened this issue Nov 8, 2024 · 0 comments · Fixed by #6513
Closed

Remove concept of array_set mut in brillig functions #6486

TomAFrench opened this issue Nov 8, 2024 · 0 comments · Fixed by #6513
Assignees
@aakoshh

Comments

@TomAFrench
Copy link
Member

See discussion in this PR, the array_set mut optimization was only intended for ACIR functions but appears to be being applied in brillig functions which causes problems as it clashes with reference counting.

We should ensure that all array_sets in brillig functions are marked as non-mutable and then revert the changes made in that PR to allow more ACIR optimizations again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakoshh aakoshh

Labels
None yet
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ssa): Skip array_set pass for Brillig functions noir-lang/noir
2 participants
@aakoshh @TomAFrench