Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input to brillig function is in a separate subgraph to output #6536

Closed
signorecello opened this issue Nov 16, 2024 · 3 comments
Closed

Input to brillig function is in a separate subgraph to output #6536

signorecello opened this issue Nov 16, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@signorecello
Copy link
Contributor

Aim

Trying to use the plume library

Expected Behavior

I expect it to work normally

Bug

I get an error:

bug: Input to brillig function is in a separate subgraph to output
    ┌─ /Users/zpedro/nargo/github.com/noir-lang/noir-bignumv0.4.1/src/fns/constrained_ops.nr:302:43302let (result, borrow_flags) = unsafe { __neg_with_flags(params, val) };
    │                                           ----------------------------- There is no path from the output of this brillig call to either return values or inputs of the circuit, which creates an independent subgraph. This is quite likely a soundness vulnerability

To Reproduce

  1. Start a new project
  2. Import and use the PLUME library
  3. Compile without the --silence-warnings flag

Workaround

Yes

Workaround Description

Using --silence-warnings makes it go away

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@signorecello signorecello added the bug Something isn't working label Nov 16, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 16, 2024
@TomAFrench
Copy link
Member

TomAFrench commented Nov 16, 2024

Either duplicate of #5518 or it's a bug in the library.

@TomAFrench TomAFrench marked this as a duplicate of #5518 Nov 16, 2024
@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 16, 2024
@signorecello
Copy link
Contributor Author

Can we check if it's a duplicate before closing this? Should I reopen it in the bignum library? I'd be wary of closing an issue if it's unclear whether this will persist after fixing #5518

@signorecello signorecello reopened this Nov 18, 2024
@TomAFrench
Copy link
Member

This is #5518.

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants