Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash in github dep url makes deps different #6720

Closed
olehmisar opened this issue Dec 6, 2024 · 0 comments · Fixed by #6725
Closed

Trailing slash in github dep url makes deps different #6720

olehmisar opened this issue Dec 6, 2024 · 0 comments · Fixed by #6725
Assignees
Labels
bug Something isn't working

Comments

@olehmisar
Copy link

Aim

bignum = { tag = "v0.4.2", git = "https://github.com/noir-lang/noir-bignum/" }

and

bignum = { tag = "v0.4.2", git = "https://github.com/noir-lang/noir-bignum" }

are considered different crates and i get this error when trying to use noir RSA with the former dep(because noir RSA uses bignum without trailing slash).


error: Expected type BigNumParams<18, 2048>, found type BigNumParams<18, 2048>
   ┌─ src/lib.nr:34:50
   │
34 │     let signature: RBN2048 = RBN2048::from_array(params, signature);
   │                                                  ------
   │

Expected Behavior

No compilation error

Bug

^^^

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

1.0.0-beta.l0

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@olehmisar olehmisar added the bug Something isn't working label Dec 6, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 6, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants