Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning for when pub is applied to trait methods #6919

Closed
TomAFrench opened this issue Jan 2, 2025 · 0 comments · Fixed by #6923
Closed

Add a warning for when pub is applied to trait methods #6919

TomAFrench opened this issue Jan 2, 2025 · 0 comments · Fixed by #6923
Assignees
@asterite

Comments

@TomAFrench
Copy link
Member

We've got a lot of pubs on the methods here which are unnecessary (as all trait methods are public)

https://github.com/noir-lang/noir-bignum/blob/1fcb2c91a9a471e511f313c15f463c3c6f987f14/src/bignum.nr#L22-L100

Ideally this is something that will throw a warning to the user and be automatically removed by the formatter.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 2, 2025
@asterite asterite self-assigned this Jan 2, 2025
@asterite asterite mentioned this issue Jan 2, 2025
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asterite asterite

Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: warn on trait method visibility noir-lang/noir
2 participants
@asterite @TomAFrench