Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nargo): add support for testing noir libraries #752

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Closes #751

Description

Summary of changes

We now only reject compiling libraries if we haven't provided an override for the main function. This allows the test binaries from nargo test to be built while retaining the helpful error message for users running nargo compile on a library.

Dependency additions / changes

N/A

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench changed the title Add support for Noir library testing feat(nargo): add support for testing noir libraries Feb 6, 2023
@TomAFrench TomAFrench requested a review from jfecher February 6, 2023 14:36
jfecher
jfecher previously approved these changes Feb 6, 2023
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This was an oversight from the original PR

@kevaundray kevaundray merged commit 27bd2ac into master Feb 6, 2023
@kevaundray kevaundray deleted the noir-library-testing branch February 6, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nargo test doesn't allow testing of libraries.
3 participants