-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nargo): Version info in nargo and wasm #802
Conversation
@kobyhallx When building fdfb71f locally I get many changes appearing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, my main issue is with the lockfile atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we looked at https://crates.io/crates/build-info ? It says it separates the git deps out so they aren't being pulled in by build. It also has WAY more downloads than the build-data crate
build-info seems to bring runtime dependency though. Also build-data makes it more transparent how to escape in alternative build scenarios like with no git available in pure nix builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issue(s)
#720 Version Hash in Nargo and wasm
Resolves #720
Description
Both Nargo and Wasm binary of noir compiler should allow to identify them based on compile time information.
Summary of changes
Adds compilation time git version hash, indication if it was build from dirty git tree.
Same applies to changes in WASM which exposes function to get this information.
Dependency additions / changes
N/A
Test additions / changes
N/A
Checklist
cargo fmt
with default settings.Additional context
N/A