fix: check the argument count of generic types #970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves the first part of #969
Description
Summary of changes
This PR issues an error when a type constructor is given an incorrect number of generic arguments. If these are not checked, we later fail an assert while instantiating struct types later on during type checking. To ensure we do not hit this assert even in the presence of bad input, we resize the generics vector on error. Either truncating it or filling it with fresh type variables until it is the desired size.
Checklist
cargo fmt
with default settings.Documentation needs