Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root Out Duplicated Code #4

Open
nojronatron opened this issue Jul 27, 2022 · 2 comments
Open

Root Out Duplicated Code #4

nojronatron opened this issue Jul 27, 2022 · 2 comments
Assignees
@nojronatron
Labels
code maintenance Code cleanup, versioning, dependency updates, etc.

Comments

@nojronatron
Copy link
Owner

"delBlankLines" has/had some.
Root out and remove duplicated code wherever possible without changing form functionality, so code is easier to read and update.
@nojronatron nojronatron changed the title Duplicated Code Root Out Duplicated Code Jul 27, 2022
@nojronatron nojronatron added the code maintenance Code cleanup, versioning, dependency updates, etc. label Jun 18, 2023
@nojronatron
Copy link
Owner Author

To the best of my understanding, this problem has been addressed in PR #36 .

@nojronatron nojronatron self-assigned this Jun 25, 2023
@nojronatron
Copy link
Owner Author

void functions AddIn, AddOut, and AddDrop are mostly duplicate code.

  1. Encapsulate the duplicated code into a single function that accepts a string parameter.
  2. Have the callers include the correct argument ('IN', 'OUT', or 'DROP') so the correct bib data is recorded.
  3. Test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nojronatron nojronatron

Labels
code maintenance Code cleanup, versioning, dependency updates, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nojronatron