Skip to content

Commit

Permalink
fix: fix source maps for ES modules (#6866)
Browse files Browse the repository at this point in the history
This commit addresses an issue with the missing ".min" part in the source map URLs, which leads to broken links for .jsm files. The problem is that the URLs are not correctly formed, causing the files to point to non-existing locations.

In this code change, we have rectified this problem by ensuring that the source map URLs now include the ".min" part. This adjustment ensures that the links to .jsm files are correctly directed to the appropriate URLs, resolving the problem of broken links.

With this fix, the source map URLs will now be accurately generated, and the .jsm files will successfully link to their corresponding source maps, resolving the previously broken links.

Fixes #6863
  • Loading branch information
Matt-Kaminski authored Jul 25, 2023
1 parent b7cf0eb commit 5e88c4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/utils/minify.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default async (fileName, filePath, bannerName) => {
const { code, map } = await minify(content, {
sourceMap: {
filename: `${fileName}${fileExt}`,
url: `${fileName}.map`,
url: `${fileName.replace(fileExt, `.min${fileExt}`)}.map`,
},
output: {
preamble: typeof bannerName !== 'undefined' ? banner(bannerName) : '',
Expand Down

0 comments on commit 5e88c4b

Please sign in to comment.