Fixed searching for images in the theme directory #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added a bit to the README documentation to clarify where images can be placed.
|
Note: the page for this template on the Dokuwiki website should be updated with the revised wording from the README if this PR is accepted. |
|
Thank you for your PR and support. Added to the current release 2022-05-05 as well as updated the Dokuwiki page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
Template->getMediaFile()was written meant that, when looking for media files in the theme directory, it prepended the absolute path of the template directory twice. E.g., it would be looking for a file at/home/username/public_html/lib/tpl/mikio//home/username/public_html/lib/tpl/mikio/themes/themename/images/logo.pngrather than simply/home/username/public_html/lib/tpl/mikio/themes/themename/images/logo.png. This pull request fixes that bug. It also clarifies the documentation in the README about where exactly the images can be placed.