-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to react-dom-factories? #32
Comments
Yup! I haven't had the time to do it recently, but it's on the list. Accepting PRs as well :) |
React 16 RC is out. This whole package will stop working shortly :( |
React 16 official reelease is today so all apps using this package can not upgrade officially. Created a shitty pull request - it shouldnt take more than 10 minutes if you know TS to simply change all the imports here |
Cool, will bundle this with a couple other fixes today! |
When using react-mosaic with React 15.6.1, you get the following warning:
react-mosaic is using React's DOM factories in the following places; just wondering if there are plans to prepare react-mosaic for React 16?
https://github.com/palantir/react-mosaic/blob/785638b21294440ce42990c0ff41b0895785c80d/src/Mosaic.ts#L31
https://github.com/palantir/react-mosaic/blob/785638b21294440ce42990c0ff41b0895785c80d/src/MosaicZeroState.ts#L22
https://github.com/palantir/react-mosaic/blob/785638b21294440ce42990c0ff41b0895785c80d/src/MosaicDropTarget.ts#L25
https://github.com/palantir/react-mosaic/blob/785638b21294440ce42990c0ff41b0895785c80d/dev/ExampleApp.ts#L38
https://github.com/palantir/react-mosaic/blob/785638b21294440ce42990c0ff41b0895785c80d/src/MosaicTile.ts#L24
https://github.com/palantir/react-mosaic/blob/785638b21294440ce42990c0ff41b0895785c80d/src/window/defaultToolbarControls.ts#L22
https://github.com/palantir/react-mosaic/blob/b3c78717f364743bb844c41e605c9d5999c3ddd5/src/window/MosaicWindow.ts#L34
The text was updated successfully, but these errors were encountered: