Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: topic label field default to indexed field if not supplied #316

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

zanussbaum
Copy link
Collaborator

@zanussbaum zanussbaum commented Jul 12, 2024

from changes: https://github.com/nomic-ai/nomic/blame/main/nomic/dataset.py#L1173
Defaulted to using topic_label_field but if NomicTopicOptions was created with no overrides, the topic_label_field is None. Set to indexed_field by default if not overridden and also handles case of image topic label field


🚀 This description was created by Ellipsis for commit cb3b8d6

Summary:

Default topic_label_field to indexed_field if not provided and handle image topic label field case in AtlasDataset.create_index method.

Key points:

  • Default topic_label_field to indexed_field if not provided in nomic/dataset.py AtlasDataset.create_index.
  • Handle image topic label field case in nomic/dataset.py AtlasDataset.create_index.
  • Update examples/map_text.py to reflect changes in AtlasDataset usage.
  • Increment version to 3.0.39 in setup.py.

Generated with ❤️ by ellipsis.dev

@zanussbaum zanussbaum requested a review from apage43 July 12, 2024 16:55
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 11dc2e8 in 43 seconds

More details
  • Looked at 78 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_SLGvzMWiigUVW36Q


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

nomic/dataset.py Outdated Show resolved Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
examples/map_text.py Outdated Show resolved Hide resolved
@zanussbaum zanussbaum merged commit 8bc157d into main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants