fix: topic label field default to indexed field if not supplied #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from changes: https://github.com/nomic-ai/nomic/blame/main/nomic/dataset.py#L1173
Defaulted to using
topic_label_field
but ifNomicTopicOptions
was created with no overrides, thetopic_label_field
is None. Set toindexed_field
by default if not overridden and also handles case of image topic label fieldSummary:
Default
topic_label_field
toindexed_field
if not provided and handle image topic label field case inAtlasDataset.create_index
method.Key points:
topic_label_field
toindexed_field
if not provided innomic/dataset.py
AtlasDataset.create_index
.nomic/dataset.py
AtlasDataset.create_index
.examples/map_text.py
to reflect changes inAtlasDataset
usage.3.0.39
insetup.py
.Generated with ❤️ by ellipsis.dev