Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: task type sagemaker #338

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix: task type sagemaker #338

merged 4 commits into from
Oct 23, 2024

Conversation

zanussbaum
Copy link
Collaborator

@zanussbaum zanussbaum commented Oct 23, 2024

task type is now part of the request body in the sagemaker image


Important

Removed preprocess_texts and integrated task type validation into embed_text in sagemaker.py, with task type now part of the request body.

  • Functionality:
    • Removed preprocess_texts function from sagemaker.py.
    • Integrated task type validation directly into embed_text function.
  • Behavior:
    • embed_text now directly asserts valid task_type values: search_query, search_document, classification, clustering.
    • Removed text preprocessing step that prefixed texts with task type.
    • Task type is now part of the request body in embed_text.
  • Misc:
    • Updated pyright version constraint in setup.py to <=pyright-1.1.377.

This description was created by Ellipsis for 91b59e0. It will automatically update as commits are pushed.

setup.py Outdated Show resolved Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@@ -48,7 +48,7 @@
"pylint",
"pytest",
"isort",
"pyright",
"pyright<=1.1.377",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I checked and the failures start showing up in .379 - so we could pin .378 here, either way I'm just happy its pinned now

@zanussbaum zanussbaum merged commit 609009f into main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants