Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Potential stack overflow on EventLoop.poll() #198

Open
lsafer-meemer opened this issue Jul 1, 2024 · 2 comments
Open

[bug] Potential stack overflow on EventLoop.poll() #198

lsafer-meemer opened this issue Jul 1, 2024 · 2 comments

Comments

@lsafer-meemer
Copy link

Here, when the channel successfully sends the records, the poll() function gets called and the current frame stuck in the stack.
Therefore, the stack will keep growing infinitely if the channel kept successfully sending the records

@nomisRev
Copy link
Owner

nomisRev commented Jul 2, 2024

Hey @lsafer-meemer,

Thank you or the bug report, and your interest in the project! Is there a reproducible snippet? We're missing quite some tests, complex scenarios are not always easy to write..

This should be testable by configuring a very low max.poll.size, and probably low poll time, to pull 20_000 records 1 by 1, successfully. A stack unsafe method should result in StackOverflow after 20_000 recursions, but we can also test 200_000 to be sure.

I'd love a contribution for this if you're interested 🙏

@lsafer-meemer
Copy link
Author

Sorry, I actually don't know how the project works 😥

I just found it when I was randomly exploring and thought it was an issue 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants