Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actual users name / email to dashboard welcome message #372

Closed
dickeyy opened this issue Jul 19, 2024 · 4 comments · Fixed by #375
Closed

Add actual users name / email to dashboard welcome message #372

dickeyy opened this issue Jul 19, 2024 · 4 comments · Fixed by #375

Comments

@dickeyy
Copy link
Contributor

dickeyy commented Jul 19, 2024

Is your feature request related to a problem? Please describe.
When the user goes to the dashboard, they should be welcomed by their name/email.

Describe the solution you'd like
When the user goes to /app, it should say "Welcome {user.firstName}" or "Welcome {user.emailAddresses[0].emailAddress}"

Describe alternatives you've considered
I mean, no welcome message I guess?

Additional context
I've implemented the fix for this already. I would like feedback before submitting a PR. here is what it looks like

image
@Erb3
Copy link
Contributor

Erb3 commented Jul 19, 2024

I feel like it should prioritize like following:

  1. first name
  2. if email includes a dot, use what comes before the dot (john.doe@example.com becomes john)
  3. otherwise use everything before the @ (johndoe@example.com becomes johndoe)

@ixahmedxi
Copy link
Collaborator

Yeah I like @Erb3's idea here.

@MUK-Dev
Copy link

MUK-Dev commented Jul 31, 2024

HI, is this issue up for grabs?

@dickeyy
Copy link
Contributor Author

dickeyy commented Jul 31, 2024

#375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants