Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn.lock erroneously included in size #5

Closed
noqcks opened this issue Dec 13, 2018 · 4 comments
Closed

yarn.lock erroneously included in size #5

noqcks opened this issue Dec 13, 2018 · 4 comments

Comments

@noqcks
Copy link
Owner

noqcks commented Dec 13, 2018

yarn.lock not being removed from total size calculation, and it should be!
@Chathula
Copy link

this must be created with a way to ignore files that we want!

@TheTechRobo
Copy link

yeah, something like a /.github/pull-request-size/ignores with a .gitignore syntax would make sense

@noqcks
Copy link
Owner Author

noqcks commented Jul 23, 2021

It is possible to exclude files in the calculation. I updated the documentation to make it more clear: https://github.com/noqcks/pull-request-size#excluding-files

@noqcks
Copy link
Owner Author

noqcks commented Oct 28, 2022

yarn.lock is actually not considered a generated file by the linguist project

see discussion

closing this issue

@noqcks noqcks closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noqcks @Chathula @TheTechRobo