Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File metadata not passed from docs page template to Video component #157

Closed
arcticicestudio opened this issue Jun 16, 2019 · 0 comments
Closed

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 16, 2019

The Video component maps the video file metadata received from props.sources (array of objects) to the <source> HTML tag, but for docs pages the MDX DocsPage component only passed down the publicUrl metadata field resulting in a array of strings. This causes the Video component failing to load the video file(s) for MDX docs pages.
To fix the invalid mapping the DocsPage component should pass down the whole video file metadata object instead of only the publicUrl (string) field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant