Modernize cmake; make cmake compatible with git submoduling #103

jlblancoc · 2020-06-01T16:18:50Z

This PR does:

Add install(EXPORT ... to cmake scripts to allow better use of exported targets.
Add build options to allow not building parts of the projects (defaults=as it was before)

ethzasl-jenkins · 2020-06-01T16:18:52Z

Can one of the admins verify this patch?

pomerlef · 2020-06-01T17:27:03Z

ok to test

CMakeLists.txt

jlblancoc · 2020-08-29T20:01:25Z

(TODO: write a test of use with find_package(libnabo))

jlblancoc · 2020-09-03T05:15:06Z

Updates:

Updated README.
Added a new cmake-usage example of how easy it's now to integrate the library since it uses cmake "exported targets":

https://github.com/ethz-asl/libnabo/blob/7d998e64e12bda8fac497c3af75b55673d47ab40/examples/libnabo-cmake-example/CMakeLists.txt#L1-L11

YoshuaNava · 2020-09-03T10:29:54Z

LGTM.

YoshuaNava · 2020-09-03T10:31:01Z

Two last comments:

On which platform did you test the changes?
@pomerlef Do you know why the Jenkins pipeline is failing? (I don't have access to the build server details)

jlblancoc · 2020-09-03T10:32:48Z

On which platform did you test the changes?

Ubutu 20.04 and 18.04 (amd64).

YoshuaNava · 2020-09-03T10:41:58Z

Oki.

All good from my side, let's wait for details on the pipeline.

YoshuaNava · 2020-09-03T10:42:47Z

Updates:

Updated README.

Added a new cmake-usage example of how easy it's now to integrate the library since it uses cmake "exported targets":

https://github.com/ethz-asl/libnabo/blob/7d998e64e12bda8fac497c3af75b55673d47ab40/examples/libnabo-cmake-example/CMakeLists.txt#L1-L11

Thank you for taking the time to do this, it's very cool 👍

pomerlef · 2020-09-03T14:45:39Z

It's not specific to a given build, they all have the following errors:

In file included from /home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/nabo_private.h:35:0,
                 from /home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/kdtree_cpu.cpp:32:

/home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/nabo.h:35:22: fatal error: Eigen/Core: No such file or directory
 #include "Eigen/Core"
                      ^
compilation terminated.
In file included from /home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/nabo_private.h:35:0,
                 from /home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/brute_force_cpu.cpp:32:

/home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/nabo.h:35:22: fatal error: Eigen/Core: No such file or directory
 #include "Eigen/Core"
                      ^
compilation terminated.
In file included from /home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/nabo.cpp:32:0:

/home/jenkins/workspace/libnabo/compiler/clang/label/ubuntu-trusty/nabo/nabo.h:35:22: fatal error: Eigen/Core: No such file or directory
 #include "Eigen/Core"
                      ^
compilation terminated.

pomerlef · 2020-09-10T17:25:41Z

ok to test

pomerlef · 2020-09-10T17:29:47Z

Same errors

jlblancoc · 2020-09-12T16:14:00Z

Same errors

I'll try to reproduce it... I think it may be related to the outdated version of Eigen in trusty.

jlblancoc · 2020-09-17T16:06:15Z

Ok, there was a missing cmake command that made the python module to fail to build.

It's fixed now, please verify and merge at your convenience.

pomerlef · 2020-09-17T18:14:31Z

Alright, I'm not sure how to handle:

default Expected — Waiting for status to be reported

Can someone from ETH how this repo was set up?

michaelpantic · 2020-09-17T20:28:13Z

Alright, I'm not sure how to handle:

default Expected — Waiting for status to be reported

Can someone from ETH how this repo was set up?

I had a look, there seems to be old build hooks in the config. Removed unreachable URLS. Let's see if it works again.

michaelpantic · 2020-09-17T20:58:08Z

@pomerlef fixed. Seems to have been a reference to a status check that does not exist anymore.

pomerlef · 2020-09-17T21:17:07Z

@michaelpantic thanks for the investigation!

peci1 · 2020-09-18T08:07:49Z

What am I doing wrong? I'm unable to compile libpointmatcher, and neither can I compile the cmake example in libnabo:

$ cd src/libnabo/examples/libnabo-cmake-example/build
$ cmake ..
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /media/data/subt/mapper/src/libnabo/examples/libnabo-cmake-example/build
$ make
Scanning dependencies of target libnabo-cmake-example
[ 50%] Building CXX object CMakeFiles/libnabo-cmake-example.dir/trivial.cpp.o
/media/data/subt/mapper/src/libnabo/examples/libnabo-cmake-example/trivial.cpp:3:10: fatal error: nabo/nabo.h: Directory or file does not exist
 #include "nabo/nabo.h"
          ^~~~~~~~~~~~~
compilation terminated.

Looking at libnabo-targets-release.cmake , there's not a word about include directories:

#----------------------------------------------------------------
# Generated CMake target import file for configuration "Release".
#----------------------------------------------------------------

# Commands may need to know the format version.
set(CMAKE_IMPORT_FILE_VERSION 1)

# Import target "libnabo::nabo" for configuration "Release"
set_property(TARGET libnabo::nabo APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(libnabo::nabo PROPERTIES
  IMPORTED_LINK_INTERFACE_LANGUAGES_RELEASE "CXX"
  IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE "gomp"
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/libnabo.a"
  )

list(APPEND _IMPORT_CHECK_TARGETS libnabo::nabo )
list(APPEND _IMPORT_CHECK_FILES_FOR_libnabo::nabo "${_IMPORT_PREFIX}/lib/libnabo.a" )

# Commands beyond this point should not need to know the version.
set(CMAKE_IMPORT_FILE_VERSION)

peci1 · 2020-09-18T08:19:32Z

This change to the generated libnabo-targets-release.cmake helps building both the example and libpointmatcher:

set_target_properties(libnabo::nabo PROPERTIES
  IMPORTED_LINK_INTERFACE_LANGUAGES_RELEASE "CXX"
  IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE "gomp"
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib/libnabo.a"
+  INTERFACE_INCLUDE_DIRECTORIES "/media/data/subt/mapper/devel/include;/usr/include/eigen3"
  )

jlblancoc · 2020-09-18T08:44:16Z

Can you please update to the latest version? It works straight away for me... and the automatically generated targets file has:

set_target_properties(libnabo::nabo PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "/usr/include/eigen3;/home/jlblanco/code/libnabo"
)

peci1 · 2020-09-18T09:14:57Z

Let's continue in #106. I am using up-to-date master version.

jlblancoc added 2 commits May 29, 2020 13:01

Make library git submodule-friendly

b7b3cc4

modernize cmake to have exported targets

e806cf5

better handling of STATIC build option

7e663a7

jlblancoc mentioned this pull request Jun 7, 2020

Modernize cmake; make cmake compatible with git submoduling norlab-ulaval/libpointmatcher#382

Merged

YoshuaNava reviewed Jun 8, 2020

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

option to disable doxygen; cmake clean up

37d7a76

add complete cmake exported-targets usage example

7d998e6

YoshuaNava approved these changes Sep 3, 2020

View reviewed changes

pomerlef approved these changes Sep 3, 2020

View reviewed changes

fix missing eigen headers in python module

b448838

pomerlef merged commit 99e58e4 into norlab-ulaval:master Sep 17, 2020

peci1 mentioned this pull request Sep 18, 2020

Fix install-space include directories #106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize cmake; make cmake compatible with git submoduling #103

Modernize cmake; make cmake compatible with git submoduling #103

jlblancoc commented Jun 1, 2020

ethzasl-jenkins commented Jun 1, 2020

pomerlef commented Jun 1, 2020

jlblancoc commented Aug 29, 2020

jlblancoc commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020 •

edited

Loading

jlblancoc commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020

pomerlef commented Sep 3, 2020 •

edited

Loading

pomerlef commented Sep 10, 2020

pomerlef commented Sep 10, 2020

jlblancoc commented Sep 12, 2020

jlblancoc commented Sep 17, 2020

pomerlef commented Sep 17, 2020

michaelpantic commented Sep 17, 2020

michaelpantic commented Sep 17, 2020

pomerlef commented Sep 17, 2020

peci1 commented Sep 18, 2020

peci1 commented Sep 18, 2020

jlblancoc commented Sep 18, 2020

peci1 commented Sep 18, 2020

Modernize cmake; make cmake compatible with git submoduling #103

Modernize cmake; make cmake compatible with git submoduling #103

Conversation

jlblancoc commented Jun 1, 2020

ethzasl-jenkins commented Jun 1, 2020

pomerlef commented Jun 1, 2020

jlblancoc commented Aug 29, 2020

jlblancoc commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020 • edited Loading

jlblancoc commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020

YoshuaNava commented Sep 3, 2020

pomerlef commented Sep 3, 2020 • edited Loading

pomerlef commented Sep 10, 2020

pomerlef commented Sep 10, 2020

jlblancoc commented Sep 12, 2020

jlblancoc commented Sep 17, 2020

pomerlef commented Sep 17, 2020

michaelpantic commented Sep 17, 2020

michaelpantic commented Sep 17, 2020

pomerlef commented Sep 17, 2020

peci1 commented Sep 18, 2020

peci1 commented Sep 18, 2020

jlblancoc commented Sep 18, 2020

peci1 commented Sep 18, 2020

YoshuaNava commented Sep 3, 2020 •

edited

Loading

pomerlef commented Sep 3, 2020 •

edited

Loading