Automaticaly find eigen3 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
pomerlef
approved these changes
Feb 13, 2021
|
I'll merge it tomorrow unless someone has more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have to set the CMake variable
EIGEN_INCLUDE_DIRmanually when installing libnabo on Windows.It would be simpler to use the environment variable
EIGEN3_INC_DIRadded when installing Eigen.To make this changes, I was inspired by the FindEigen3.cmake file from CGAL.
I didn't take the whole file which is very complete and secure, but only the part that find Eigen path.
I was not able to test these modifications on Linux. So it should be done before merge.