Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect new changes in libnabo. #404

Closed
wants to merge 1 commit into from

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 18, 2020

I got build failures with the latest changes in libnabo. This PR fixes them. Requires norlab-ulaval/libnabo#106 if building with catkin tools. The change in Config file is needed by downstream packages, e.g. libpointmatcher_ros.

@YoshuaNava
Copy link
Contributor

Hi @peci1
Sorry for the issue. There is another PR aimed to updating libpointmatcher's cmake (#382), as we did for libnabo. It seems close to merging.

@pomerlef This fix patches libpointmatcher, until the other PR is merged. Two questions:

  1. Why is the build failing? (I don't have access to the CI job details)
  2. Should we merge this PR before the larger one from @jlblancoc ?

Best,
Yoshua

@pomerlef
Copy link
Collaborator

I would directly focus on #382

Error message:

/home/jenkins/workspace/pointmatcher/label/ubuntu-xenial/pointmatcher/MatchersImpl.h:41:23: fatal error: nabo/nabo.h: No such file or directory
compilation terminated.
CMakeFiles/pointmatcher.dir/build.make:158: recipe for target 'CMakeFiles/pointmatcher.dir/pointmatcher/ICP.cpp.o' failed

make[2]: *** [CMakeFiles/pointmatcher.dir/pointmatcher/ICP.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/jenkins/workspace/pointmatcher/label/ubuntu-xenial/pointmatcher/Registry.cpp:41:0:

/home/jenkins/workspace/pointmatcher/label/ubuntu-xenial/pointmatcher/MatchersImpl.h:41:23: fatal error: nabo/nabo.h: No such file or directory
compilation terminated.
CMakeFiles/pointmatcher.dir/build.make:182: recipe for target 'CMakeFiles/pointmatcher.dir/pointmatcher/Registry.cpp.o' failed

make[2]: *** [CMakeFiles/pointmatcher.dir/pointmatcher/Registry.cpp.o] Error 1
In file included from /home/jenkins/workspace/pointmatcher/label/ubuntu-xenial/contrib/yaml-cpp-pm/include/yaml-cpp-pm/yaml.h:8:0,
                 from /home/jenkins/workspace/pointmatcher/label/ubuntu-xenial/pointmatcher/Registrar.cpp:6:

/home/jenkins/workspace/pointmatcher/label/ubuntu-xenial/contrib/yaml-cpp-pm/include/yaml-cpp-pm/parser.h:46:8: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
   std::auto_ptr<Scanner> m_pScanner;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants