Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveRecord storage support #8

Closed
jefflunt opened this issue Apr 17, 2013 · 1 comment
Closed

Add ActiveRecord storage support #8

jefflunt opened this issue Apr 17, 2013 · 1 comment

Comments

@jefflunt
Copy link
Owner

While writing to a log file is great and all, it completely falls short in the area of reporting. Slicing the metrics in any arbitrarily complex way is a major strength of anything SQL-based.

I'll keep the simple log file storage and basic slowest_actions method around, but want to add :active_record as an option for collector/reporter so that users who want more, or just more fine grained, reporting capabilities can do so easily.

@jefflunt
Copy link
Owner Author

This feature is actually being canceled. In talks with other engineers I've been convinced that storage is not really the goal that will help here.

This will be replaced by up to two things:

  • Log file injection of custom data, instead of writing to a separate log file
  • Log file parsing to get that data back and report on it

How one might store this data to make it reportable is probably a concern that how_slow should not worry about - it should instead emit objects which can be easily serialized into whatever storage (memory, database, file, whatever) of the user's choice.

Essentially, how_slow needs to forever be focused on making it possible to capture the data that a programmer deems necessary to properly measure their app.

I'm even considering not doing log parsing at all, many solutions already exist for this from already existing gems to commercial log analyzers and aggregators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant