Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Evaluate Curve" node outputs weird FreeCAD tangents values #3652

Closed
rendetto opened this issue Oct 15, 2020 · 7 comments
Closed

"Evaluate Curve" node outputs weird FreeCAD tangents values #3652

rendetto opened this issue Oct 15, 2020 · 7 comments
Assignees
Labels

Comments

@rendetto
Copy link
Contributor

FreeCAD curve tangents output differs from SV and Geomdl

FreeCAD_NURBS_Curve_Tangents_Issue2

This is the test file I'm using:
FreeCAD_NURBS_Curve_Tangents_Issue2.zip

@portnov
Copy link
Collaborator

portnov commented Oct 16, 2020

I suspect they are just not normalized...

@portnov portnov added the NURBS label Oct 16, 2020
@rendetto
Copy link
Contributor Author

rendetto commented Oct 16, 2020

You seem right, because the direction looks the same, although after a normalize the values didn't change (weird?)

FreeCAD_NURBS_Curve_NormalizeTangents

The other thing I found is with the Curvature and Torsion values. Again FreeCAD differs from other implementations.
FreeCAD_NURBS_Curve_Properties_Issues

Here's the file:
FreeCAD_NURBS_Curve_Issues.zip

@rendetto
Copy link
Contributor Author

Also normals and binormals have slight differences at T=0.0 and T=1.0
FreeCAD_NURBS_Curve_Properties_Issues_Frame

Test file updated:
FreeCAD_NURBS_Curve_Issues.zip

@rendetto
Copy link
Contributor Author

A small off-topic:
I just checked the surfaces(normals, tangents, curvatures) and there are no such problems.

@Durman Durman closed this as completed Nov 9, 2020
@rendetto
Copy link
Contributor Author

rendetto commented Nov 9, 2020

Just checked the test file I did, and none of the above issues are solved. @portnov can you check that?
Thanks

@portnov portnov reopened this Nov 9, 2020
@portnov portnov self-assigned this Nov 9, 2020
@rendetto
Copy link
Contributor Author

rendetto commented Dec 28, 2020

A small update here.
It appears that FreeCAD tangent vectors are in fact OK. FreeCAD tangents are normalized by default in oppose to Geomdl and Sverchok ones. That explains why, when I normalized a FreeCAD tangent, its value didn't change.
FreeCAD_Tangents

Still no clue why curvature and torsion are so different.
@portnov I guess we can close this issue and open one specifically for Curve Frame, Curvature and Torsion output?

@rendetto
Copy link
Contributor Author

Closing this issue and opened one for Curve Curvature #3804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants