fix #5049. Logic Functions cannot recreate node #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Durman
reviewed
Nov 8, 2023
| @@ -118,13 +118,47 @@ def rclick_menu(self, context, layout): | |||
| layout.prop(self, "output_numpy", expand=False) | |||
|
|
|||
| def migrate_from(self, old_node): | |||
There was a problem hiding this comment.
I think I would prefer like this:
def migrate_from(self, old_node):
if old_node.bl_idname == 'SvLogicNodeMK2':
returnThere was a problem hiding this comment.
I meant that this is the only changes which are required for the node to work properly.
- Refactor migrate_from
|
merge this if it works |
zeffii
reviewed
Nov 21, 2023
| elif old_node_input_B and hasattr(old_node_input_B, 'default_property_type'): | ||
| self.inputs['B'].default_property_type = old_node_input_B.default_property_type | ||
| self.inputs['B'].use_prop = True # like sv_init | ||
| self.inputs['B'].show_property_type = True |
There was a problem hiding this comment.
wow, these 40 lines are painful :) .. but if it must be so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5049. Logic Functions cannot recreate node. Fixed
New node created with all settings of old node.