Skip to content

Commit

Permalink
fix(dialogs.scss): Separate dialog text color from border color
Browse files Browse the repository at this point in the history
Previously, we were using the `color` property to determine the color of the border around `<dialog
/>` elements. The issue with this is that it requires the text color to match the border color. I've
fixed this by moving the border color declarations into the `box-shadow` property.
  • Loading branch information
trezy committed Dec 19, 2018
1 parent 72025cc commit d0c6746
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions scss/elements/dialogs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
}

&.is-rounded {
color: $base-color;
border: none;
box-shadow: 4px 0, -4px 0, 0 4px, 0 -4px;
box-shadow: 4px 0 $base-color, -4px 0 $base-color, 0 4px $base-color, 0 -4px $base-color;
}
}

0 comments on commit d0c6746

Please sign in to comment.