Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): add whatsapp icon #122

Merged
merged 5 commits into from
Dec 9, 2018
Merged

feat(icons): add whatsapp icon #122

merged 5 commits into from
Dec 9, 2018

Conversation

guastallaigor
Copy link
Member

image

@guastallaigor guastallaigor changed the base branch from master to develop December 8, 2018 17:44
@abdallahalsamman
Copy link
Member

@guastallaigor This is too pixelated. can we do better? It doesn't feel right 🙏

@abdallahalsamman abdallahalsamman added the waiting - contributor Waiting for the contributor to address some situations label Dec 8, 2018
@guastallaigor
Copy link
Member Author

@evexoio Not sure what to do.. I grab the idea from here. But I will think of something or do some research on it.

@jjspace
Copy link
Contributor

jjspace commented Dec 8, 2018

@guastallaigor I think that one you linked works a little better because the phone handle is thicker and the circle seems more smoothed out, specifically the top right corner. Any reason we can't just use that design?

@guastallaigor
Copy link
Member Author

@guastallaigor I think that one you linked works a little better because the phone handle is thicker and the circle seems more smoothed out, specifically the top right corner. Any reason we can't just use that design?

None, I just didn't want to make a copy 😄 but that's fine I will do it.

@guastallaigor
Copy link
Member Author

Now I think it looks like the image I provided:

image

jjspace
jjspace previously approved these changes Dec 9, 2018
View reviewed changes
Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abdallahalsamman
abdallahalsamman approved these changes Dec 9, 2018
View reviewed changes
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

Whatsapp is a hard one 👍

@abdallahalsamman abdallahalsamman merged commit 629a204 into nostalgic-css:develop Dec 9, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guastallaigor guastallaigor removed the waiting - contributor Waiting for the contributor to address some situations label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdallahalsamman abdallahalsamman abdallahalsamman approved these changes

@jjspace jjspace jjspace left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guastallaigor @abdallahalsamman @jjspace @BcRikko