Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): empty trophy + is-small modifier #128

Conversation

Kartones
Copy link
Contributor

@Kartones Kartones commented Dec 8, 2018

  • Adds a is-small css modifier (like is-medium or is-large) that renders at half the resolution (16x16 instead of 32x32). I plan to use it for certain places like icons at the footer or at container titles if those are small.
  • Adds empty version of the trophy icon

Screenshot with the is-small version before the standard one (image was from previous PR done against master):
screenshot

@jjspace
Copy link
Contributor

jjspace commented Dec 8, 2018

Just for future reference you can just edit a PR to change the branch it's merging to as @evexoio did with #126

Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🙌

@abdallahalsamman abdallahalsamman merged commit e757098 into nostalgic-css:develop Dec 9, 2018
@Kartones Kartones deleted the empty-trophy-and-is-small branch December 9, 2018 11:04
@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants