-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): add phone and smartphone icons #131
feat(icons): add phone and smartphone icons #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose removing the apple logo from the phone and just leave it looking like a generic smartphone. Also a bit nit-picky but did you mean to leave the speaker bar at the top asymmetric?
As for the handheld receiver most of our icons thus far have a very flat appearance. This one almost seems to have some gradient. thoughts on making it one color? or just a subtle 1px wide shadow like the trophy cup?
That looks much better, I like it. |
@jjspace Yeah I know, but that's a lot harder to make for me 😆 . But I will give it a shot. |
Haha yea I know so don't worry about it too much, just a thought |
@jjspace But I got an idea, what if I just rotate it -45deg? What do you think of this? |
First off I think that handheld looks much better with the style we've been creating, nice job! As for rotating I'm not sure how I feel about it, might need others opinions on it. My thoughts are that I'm hesitant to use the transform and would kinda rather let the consumer do that themselves if they want it. But in addition to that it doesn't exactly make sense from a pixel art perspective. You cant just reach into a screen and rotate how it draws pixels or the arrangement of leds in a screen so it doesn't exactly make sense to have diagonal lines like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @guastallaigor thanks for the icons!
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please check if this icons is ok to close #65 :