Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(containers.scss): fix alignment of title #136

Merged
merged 4 commits into from
Dec 9, 2018
Merged

fix(containers.scss): fix alignment of title #136

merged 4 commits into from
Dec 9, 2018

Conversation

BcRikko
Copy link
Member

@BcRikko BcRikko commented Dec 9, 2018

Many changes have been detected, but I just fixed margin of is-center > .title and properties order. 🛠

before after
container after

@BcRikko BcRikko added the bug Something isn't working label Dec 9, 2018
@BcRikko BcRikko self-assigned this Dec 9, 2018
@BcRikko BcRikko requested a review from a team December 9, 2018 03:21
@jjspace
Copy link
Contributor

jjspace commented Dec 9, 2018

LGTM but I can't officially add my review without being in the org

@abdallahalsamman
Copy link
Member

With title: looks good 👍

with-title

With title, is rounded: is this intended behavior?

is-rounded-with-title

@BcRikko
Copy link
Member Author

BcRikko commented Dec 9, 2018 •
edited
Loading

umm……
After pulling fix-alignment-of-title branch and rebuilding it,
then it looks like the image below in my environment. 🤔
alignment

abdallahalsamman
abdallahalsamman approved these changes Dec 9, 2018
View reviewed changes
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I had to npm run build instead of npm run watch, my bad 🙈

Can you fix conflicts please?

@BcRikko
Copy link
Member Author

BcRikko commented Dec 9, 2018

I fixed it 🛠

@abdallahalsamman abdallahalsamman merged commit a9c9592 into develop Dec 9, 2018
@abdallahalsamman abdallahalsamman deleted the fix-alignment-of-title branch December 9, 2018 19:09
@BcRikko
Copy link
Member Author

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdallahalsamman abdallahalsamman abdallahalsamman approved these changes

Assignees

@BcRikko BcRikko

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BcRikko @jjspace @abdallahalsamman