Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<select> component #152

Closed
4k1k0 opened this issue Dec 10, 2018 · 14 comments
Closed

<select> component #152

4k1k0 opened this issue Dec 10, 2018 · 14 comments
Labels
enhancement New feature or request

Comments

@4k1k0
Copy link
Contributor

4k1k0 commented Dec 10, 2018

Hello.

I would like to see a <select> component in the framework.

I made this but I'm not very confident about the desing. What do you think? Should I make a pull request?

captura de pantalla_2018-12-09_20-20-03

Thanks.

@guastallaigor guastallaigor added the enhancement New feature or request label Dec 10, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 10, 2018

Great 🎉

Could you make four corners missing? like below 🤔
2018-12-10 11 46 44

and Could you pixelize ? like below 🤔
2018-12-10 11 49 05

@4k1k0
Copy link
Contributor Author

4k1k0 commented Dec 10, 2018

What do you think?
captura de pantalla_2018-12-09_21-12-11

@BcRikko
Copy link
Member

BcRikko commented Dec 10, 2018

like this 😆
2018-12-10 12 16 37

@4k1k0
Copy link
Contributor Author

4k1k0 commented Dec 10, 2018

Oh my mistake I used the wrong mixing.
captura de pantalla_2018-12-09_21-18-43

@BcRikko
Copy link
Member

BcRikko commented Dec 10, 2018

oh, great 😆 🎉

@4k1k0 4k1k0 mentioned this issue Dec 10, 2018
@panoramix360
Copy link

I was doing a select too 😆

Until now, it is like this, but since you already did it, I think I'll try to make another element to help :)

screen shot 2018-12-10 at 14 20 41

There is something on the roadmap @BcRikko ?

@nicanordlc
Copy link

<3

@BcRikko
Copy link
Member

BcRikko commented Dec 10, 2018

sorry, there is no roadmap. 😢

I just came up with following elements. 🤔

  • <input type="range">
  • <ul>〜</ul>

@panoramix360
Copy link

panoramix360 commented Dec 10, 2018

Ok!! I'll try to make some new elements then. 😃

@trezy trezy mentioned this issue Dec 11, 2018
5 tasks
@trezy
Copy link
Member

trezy commented Dec 13, 2018

@4k1k0, I see that you deleted the branch that you were originally using to create this component. Are you still planning on making a PR for it at some point?

@trezy trezy added the waiting - contributor Waiting for the contributor to address some situations label Dec 13, 2018
@4k1k0
Copy link
Contributor Author

4k1k0 commented Dec 13, 2018

@trezy oh sorry, i didn't realise i deleted the branch. 🙇 I will check it out 😄

@Divoolej
Copy link
Contributor

For anyone coming here from with a React background wondering how to implement a select component that would look good with this library - I've created a simple React-Select theme compatible with NES.css styles: https://github.com/Divoolej/react-select-nes-css-theme

It looks like this:
screenshot 2018-12-20 at 00 20 29
screenshot 2018-12-20 at 00 20 38
Maybe this could serve as an example for how a regular <select> tag could look like with NES.css?

@trezy
Copy link
Member

trezy commented Dec 20, 2018

@Divoolej that looks fantastic! It looks like @4k1k0 is having some issues with getting <select /> styles added to the repo, so if you wanted to make a PR to add these styles I think we'd all be pretty stoked about it. 😁

@Divoolej
Copy link
Contributor

Thanks @trezy 😄 There you go! -> #217 :)

@BcRikko BcRikko removed the waiting - contributor Waiting for the contributor to address some situations label Dec 23, 2018
@BcRikko BcRikko closed this as completed Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants