-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad contrast in colors #375
Comments
I looked into it a while back, but the main reason is because of this issue #27. |
Prioritize a11y is always a good choice. It's not for google or any company, but for color blind users. These issues have nothing with a11y, but just about design. |
@guastallaigor Thanks for your response 😆👍 I was also aware of this issue when I improved the performance of the demo page. However, many sites use NES.css via the CDN, so we have to be careful about changing colors. 🤔 Please let me think about how to deal with it. 🙇 |
@BcRikko LGTM! I can make some changes and open a WIP Pull request. |
Is your feature request related to a problem? Please describe.
When you try to check the audits, Lighthouse says that almost all colors have a bad contrast:
Describe the solution you'd like
I can edit all colors to have a better contrast. I've been working with A11Y for a few years.
Describe alternatives you've considered
I think we can match at least AA to help our color blind users.
![Screen Shot 2019-10-29 at 04 18 09](https://user-images.githubusercontent.com/14945222/67745519-3acefb80-fa03-11e9-8864-12d6eebf7694.png)
The text was updated successfully, but these errors were encountered: