Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Sequence reuse #8

Open
not-elm opened this issue May 3, 2024 · 1 comment
Open

[Feature] Sequence reuse #8

not-elm opened this issue May 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@not-elm
Copy link
Owner

not-elm commented May 3, 2024

This issue is about a new feature proposed from below.

Below is a quote from the PR.


Future Idea

One idea to consider for the future is making the key sequence that was pressed available somehow. Maybe something simple like this:

#[derive(Resource)]
struct LastKeySequence(Option<Vec<KeyChord>>)

But maybe that's too simple. What'd be best is if we could optionally pass the key sequence to the system we're invoking. But I don't really know how to do that.

@not-elm not-elm added the enhancement New feature or request label May 3, 2024
@not-elm not-elm mentioned this issue May 3, 2024
@shanecelis
Copy link
Collaborator

I suggested this feature, but I ended up implementing this in bevy_minibuffer without needing any special handling by bevy-input-sequence. What I did was when I registered my key sequence on the action, I simply registered the set key sequence to a resource.

So I'm all for keeping this crate simpler when possible. I'd be happy to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants