From bca6e68b6c9d384947f36a198ceb7c9deb27d5fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?colin=20axn=C3=A9r?= <25233464+colin-axner@users.noreply.github.com> Date: Mon, 15 Mar 2021 13:03:45 +0100 Subject: [PATCH] Update AllowUpdate defaults to true (#455) * use sensible defaults * update CHANGELOG --- CHANGELOG.md | 8 ++++++++ cmd/raw.go | 4 ++-- relayer/chain.go | 3 +++ relayer/client.go | 8 ++++---- 4 files changed, 17 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 934348162e3..e4ec67f8102 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,14 @@ ### Relayer +* [\#455](https://github.com/cosmos/relayer/pull/455) Set default client parameter to allow governance to update the client if expiry or misbehaviour freezing occurs. + +## v0.8.3 + +**2021/03/12** + +### Relayer + * [\#453](https://github.com/cosmos/relayer/pull/453) Fix light block not found error on missing header * [\#449](https://github.com/cosmos/relayer/pull/449) Close database connection even if error occurs on initialization * [\#447](https://github.com/cosmos/relayer/pull/447) Add a light client database lock to prevent concurrency panics diff --git a/cmd/raw.go b/cmd/raw.go index 0d0306ca4fb..58fdce66d06 100644 --- a/cmd/raw.go +++ b/cmd/raw.go @@ -117,8 +117,8 @@ $ %s tx raw clnt ibc-1 ibc-0 ibconeclient`, appName, appName)), dstHeader.GetHeight().(clienttypes.Height), commitmenttypes.GetSDKSpecs(), relayer.DefaultUpgradePath, - false, - false, + relayer.AllowUpdateAfterExpiry, + relayer.AllowUpdateAfterMisbehaviour, ) return sendAndPrint([]sdk.Msg{chains[src].CreateClient( diff --git a/relayer/chain.go b/relayer/chain.go index 469b9ca8e8c..b7e6df55de5 100644 --- a/relayer/chain.go +++ b/relayer/chain.go @@ -43,6 +43,9 @@ var ( rtyAtt = retry.Attempts(rtyAttNum) rtyDel = retry.Delay(time.Millisecond * 400) rtyErr = retry.LastErrorOnly(true) + + AllowUpdateAfterExpiry = true + AllowUpdateAfterMisbehaviour = true ) // Chain represents the necessary data for connecting to and indentifying a chain and its counterparites diff --git a/relayer/client.go b/relayer/client.go index 0a27accb404..02ad528318e 100644 --- a/relayer/client.go +++ b/relayer/client.go @@ -50,8 +50,8 @@ func (c *Chain) CreateClients(dst *Chain) (modified bool, err error) { dstUpdateHeader.GetHeight().(clienttypes.Height), commitmenttypes.GetSDKSpecs(), DefaultUpgradePath, - false, - false, + AllowUpdateAfterExpiry, + AllowUpdateAfterMisbehaviour, ) // Check if an identical light client already exists @@ -113,8 +113,8 @@ func (c *Chain) CreateClients(dst *Chain) (modified bool, err error) { srcUpdateHeader.GetHeight().(clienttypes.Height), commitmenttypes.GetSDKSpecs(), DefaultUpgradePath, - false, - false, + AllowUpdateAfterExpiry, + AllowUpdateAfterMisbehaviour, ) // Check if an identical light client already exists