Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumption of 64k stack breaks various devices #10

Open
randomouscrap98 opened this issue Sep 15, 2024 · 2 comments
Open

Assumption of 64k stack breaks various devices #10

randomouscrap98 opened this issue Sep 15, 2024 · 2 comments

Comments

@randomouscrap98
Copy link

I know it's a bit silly, but many devices have a stack size of 32k. As such, this library crashes with some pretty interesting results, and it was difficult to track down (the device in question was a 3DS, and I didn't have the luxury of messages telling me the stack died).

I know it's a bit of an ask, but would it be at all possible to have a compiler flag for "small stacks" which mallocs these 64k arrays?

@notnullnotvoid
Copy link
Owner

Thanks for letting me know. I didn't expect someone would use this library on the 3DS, that's very cool! In the interest of keeping things simple, I'll probably just make it always allocate, rather than adding a flag, since there shouldn't be any major detriment to doing so. I'll try and put that together with some other small improvements for a v2.3 of the library when I have time this week.

@randomouscrap98
Copy link
Author

Oh awesome! There's no rush, I already modified the library locally to use malloc and it works great; thank you for making such a cool library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants