Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Arabic v2.011: numerals on subtending marks are too light in weight #217

Open
eliheuer opened this issue Nov 1, 2023 · 2 comments

Comments

@eliheuer
Copy link

eliheuer commented Nov 1, 2023

Font

Noto Sans Arabic v2.011

Where the font came from, and when

QA report from this PR: google/fonts#6859

Issue

Numerals on subtending marks are too light in weight.

Screenshot

Before
Screenshot 2023-11-01 at 10 30 05 AM
After
Screenshot 2023-11-01 at 10 30 14 AM

@khaledhosny This is your call if this is worth fixing, it seems like a regression to me but I could be wrong.

@khaledhosny
Copy link
Contributor

khaledhosny commented Nov 1, 2023

They are too light because they are smaller and were scaled down without optical compensation. I think the digits are too small but that is because of the existing sign design.

I wouldn’t consider it a regression, since the before was completely broken. But it is an enhancement that should be considered in the future.

@eliheuer
Copy link
Author

eliheuer commented Nov 1, 2023

Ok thanks, this is not a blocker for the v2.011 PR then, but I'm not going to close this issue so it can be considered as an enhancment in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants