Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different directory structures in symmetric release assets: w/ or w/o junk directory names #262

Open
muzimuzhi opened this issue Dec 5, 2023 · 0 comments

Comments

@muzimuzhi
Copy link

Is your feature request related to a problem? Please describe.

Most Sans release assets are zipped using junk directory names (the zip flag -l), but their corresponding Serif release assets keep directories.

Taking language specific OTFs Japaneses for Sans and Serif as a pair of examples,

zip -j -r -v 06_NotoSansCJKjp.zip OTF/Japanese LICENSE --exclude "*.zip" "*.DS_Store"

zip -r -v 07_NotoSerifCJKjp.zip OTF/Japanese LICENSE --exclude "*.zip" "*.DS_Store"

$ unzip -l 06_NotoSansCJKjp.zip
Archive:  06_NotoSansCJKjp.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 17032620  04-30-2021 19:04   NotoSansCJKjp-Bold.otf
 17828280  04-30-2021 19:04   NotoSansCJKjp-Black.otf
 16467736  04-30-2021 19:04   NotoSansCJKjp-Regular.otf
 14927060  04-30-2021 19:04   NotoSansCJKjp-Thin.otf
 16554004  04-30-2021 19:04   NotoSansCJKjp-Medium.otf
 16360020  04-30-2021 19:04   NotoSansCJKjp-Light.otf
 16445132  04-30-2021 19:04   NotoSansCJKjp-DemiLight.otf
     4301  03-20-2022 10:36   LICENSE
---------                     -------
115619153                     8 files

$ unzip -l 07_NotoSerifCJKjp.zip
Archive:  07_NotoSerifCJKjp.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  08-15-2023 15:31   OTF/Japanese/
 24425344  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Light.otf
 24724232  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Medium.otf
 24635344  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-SemiBold.otf
 25456164  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Bold.otf
 21327140  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-ExtraLight.otf
 24456012  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Regular.otf
 24034448  08-17-2023 09:09   OTF/Japanese/NotoSerifCJKjp-Black.otf
     4301  08-17-2023 09:09   LICENSE
---------                     -------
169062985                     9 files

This difference was introduced since the first commit for release scripts, b4f6497.

Describe the solution you'd like

Ideally I prefer junk directory names, but improving consistency means introducing breaking changes, hence I'm not sure if any change should happen.

@muzimuzhi muzimuzhi changed the title Different directory structures in release assets: with or without junk directory names Different directory structures in symmetric release assets: w/ or w/o junk directory names Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant