feat: show multisig only for available networks #124
+77
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asmadek
approved these changes
May 17, 2024
| import { Chain } from "../models/Chain"; | ||
| import { MultisigVersionStorage } from "../models/MultisigVersionStorage"; | ||
|
|
||
| const repoUrl = 'https://api.github.com/repos/novasamatech/subquery-proxy/contents/'; | ||
|
|
||
| async function fetchYamlFiles(): Promise<any[]> { |
There was a problem hiding this comment.
Maybe use more meaningful name? fetchSubqueryConfigs for example
| import { Chain } from "../models/Chain"; | ||
| import { MultisigVersionStorage } from "../models/MultisigVersionStorage"; | ||
|
|
||
| const repoUrl = 'https://api.github.com/repos/novasamatech/subquery-proxy/contents/'; |
There was a problem hiding this comment.
Should it be subquery-proxy not multisig?
There was a problem hiding this comment.
Yes, right now it is subquery-proxy, maybe it will be renamed in the future
There was a problem hiding this comment.
it certainly should, this will be misleading for many otherwise. Should I create an issue?
|
@stepanLav this PR should not be merged until new multisig are implemented and released. |
ok, changed to the draft |
tuul-wq
approved these changes
May 23, 2024
Tbaut
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.