This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Integrate SpotBugs #209
Merged
Integrate SpotBugs #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Android tests and exclude tests are ignored.
The office `excludeFilter` with an xml file can be used
mr-archano
previously approved these changes
Oct 29, 2019
mr-archano
approved these changes
Oct 30, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little bit history
I've tried many times to have good setup with SpotBugs by trying to hook that into our existing
CodeQualityConfiguratorsystem. I especially tried that since SpotBugs also use Gradle's internal APIs (aka.CodeQualityPlugin)It turned out that it is really hard. SpotBugs is moving away from internal APIs (good thing) anyways.
Solution
I copied the tests since our expectations are very similar 🚀
I didn't really copy the implementation from
FindbugsConfigurator. Instead, I created from scratch. Worked quite well.For now, I didn't include the custom
excludesupport that we have for others. Basically users will need to follow SpotBugs documentation and user their APIs to exclude classes.Fixes #142