From a2dda447d67c2aff2796229546b740ea6a2a3304 Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Tue, 6 Aug 2019 03:04:33 +0200 Subject: [PATCH 1/4] Add a workaround for #176 The `@(NativeReference)` is used for other things in .NET, so make sure to remove the incorrect file. https://github.com/onovotny/MSBuildSdkExtras/issues/176 --- .../Build/LanguageTargets/Xamarin.targets | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets index f0cb5a9..8c8305f 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets @@ -34,4 +34,12 @@ - \ No newline at end of file + + + + <_BuiltProjectOutputGroupOutputIntermediate Remove="$(OutDir)$(_DeploymentTargetApplicationManifestFileName)" /> + + + + + From a20ddff453d32c768f6c8bb7b72d69599f5276a7 Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Tue, 13 Aug 2019 02:23:25 +0200 Subject: [PATCH 2/4] Added a test case that will fail when packing --- Tests/ClasslibraryAsSdk/ClasslibraryAsSdk.csproj | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Tests/ClasslibraryAsSdk/ClasslibraryAsSdk.csproj b/Tests/ClasslibraryAsSdk/ClasslibraryAsSdk.csproj index b1b12a5..680c43b 100644 --- a/Tests/ClasslibraryAsSdk/ClasslibraryAsSdk.csproj +++ b/Tests/ClasslibraryAsSdk/ClasslibraryAsSdk.csproj @@ -32,6 +32,10 @@ + + + + From ae0e944d5813493020eeeaafc3c468ee9ba871c1 Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Tue, 13 Aug 2019 02:23:51 +0200 Subject: [PATCH 3/4] Native references can be used in non-binding projects --- .../MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets index 8c8305f..0b9ec01 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets @@ -34,8 +34,8 @@ - - + + <_BuiltProjectOutputGroupOutputIntermediate Remove="$(OutDir)$(_DeploymentTargetApplicationManifestFileName)" /> From bb2a609932c420aeb1ce2c75acb4cca780554c9c Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Tue, 13 Aug 2019 02:24:39 +0200 Subject: [PATCH 4/4] fix whitespace --- Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets index 0b9ec01..89c0370 100644 --- a/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets +++ b/Source/MSBuild.Sdk.Extras/Build/LanguageTargets/Xamarin.targets @@ -42,4 +42,4 @@ - + \ No newline at end of file