Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Access actor information from notification templates #3583

Closed
2 tasks done
richardbutler opened this issue Jun 13, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels

Comments

@richardbutler
Copy link

🔖 Feature description

Allow notification templates to access information provided by the actor's subscriber object.

🎤 Why is this feature needed ?

I want to add a simple connection request notification - "John Smith would like to connect". At present, I'm sending { firstName, lastName } as part of the payload, but this is duplicate data as this is also available via the actor (I'm sending { actor: { ... } } alongside the payload: { ... }. It doesn't appear in the default variables when creating a notification template, but it seems like an obvious thing to be able to use, as {{ actor.firstName }}, for example.

✌️ How do you aim to achieve this?

Currently, actor information isn't passed into the template builders, it should be a straightforward change to make this available.

🔄️ Additional Information

I tried various variable accessors in the template builder UI but none of them worked. On submitting a query to Discord, I was asked to create an issue for this use case.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@ainouzgali
Copy link
Contributor

Thank you @richardbutler ! Assigned you :) Let us know if you need anything

@LetItRock
Copy link
Contributor

the actor variables were implemented in this PR and are released in Novu Cloud ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants